Change Scheme.Build.targets spec #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-malik
reviewed
Dec 21, 2017
| } | ||
| self.targets = targets.sorted { $0.target < $1.target } |
There was a problem hiding this comment.
Do we need to sort here? I believe xcproj will sort the targets before serializing
There was a problem hiding this comment.
xcproj just writes them in the order they are received https://github.com/xcodeswift/xcproj/blob/master/Sources/xcproj/XCScheme.swift#L251
yonaskolb
force-pushed
the
scheme_build_types
branch
from
68d0ed6 to
a53b3b9
Compare
pepicrft
approved these changes
Dec 23, 2017
|
Another benefit of this is it's impossible to duplicate targets that will be built. It also play's nice with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just learned that the order of targets in a Scheme's build settings has no affect, and in fact when you reorder them, nothing gets changed in the project.
Within this in mind, this tweaks the Scheme.build.targets to be a bit simpler and mirrors the changes in #54. The change can be seen in the documentation diffs.
As a dictionary wouldn't be in a stable order for diffs, the targets are sorted by name.
Technically this is a breaking change, which is the reason I didn't document Schemes until now, so the format could be locked down.
Any thoughts?