Default SKIP_INSTALL to YES for static libraries
#358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. Should there be any other settings in here? Anything from https://github.com/yonaskolb/XcodeGen/blob/master/SettingPresets/Products/framework.yml? |
|
Nope. All the other settings apply to bundles. Sent with GitHawk |
yonaskolb
approved these changes
Jul 24, 2018
acecilia
added a commit
to acecilia/XcodeGen
that referenced
this pull request
Apr 2, 2020
…LL: 'YES' was resulting in invalid archives when archiving. See yonaskolb#358 and https://stackoverflow.com/a/26563115/3203441 for further references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Child of #350. Addresses 4.
SKIP_INSTALLbeingNOby default for static libraries results in invalid archives.