Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project Spec includes #44

Merged
merged 2 commits into from
Aug 30, 2017
Merged

Project Spec includes #44

merged 2 commits into from
Aug 30, 2017

Conversation

yonaskolb
Copy link
Owner

@yonaskolb yonaskolb commented Aug 30, 2017 •
edited
Loading

Resolves #22

allows for include property

name: MyCoolSpec
include: [base.yml, settings.yml]

@yonaskolb yonaskolb requested a review from pepicrft August 30, 2017 11:03
@pepicrft
Copy link

pepicrft commented Aug 30, 2017 •
edited
Loading

Hey @yonaskolb. I'm not sure if I get the purpose of this property. What's the use case? I read the issue but I don't understand it at all.

@yonaskolb
Copy link
Owner Author

@pepibumur, it means you can reference other spec files within a spec, and they will be loaded and merged into the spec.

pepicrft
pepicrft approved these changes Aug 30, 2017
View reviewed changes
Copy link

@pepicrft pepicrft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL, for a while I was very confused. I thought you referred to tests with "spec". I got it now :trollface:. Looks good! Very useful feature.

@yonaskolb yonaskolb changed the title Spec includes Project Spec includes Aug 30, 2017
@yonaskolb yonaskolb merged commit f646e07 into master Aug 30, 2017
@yonaskolb yonaskolb deleted the includes branch August 30, 2017 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepicrft pepicrft pepicrft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yonaskolb @pepicrft