Don't generate CFBundleExecutable for targets of type bundle #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giginet
approved these changes
Oct 22, 2019
| @@ -8,20 +8,26 @@ public class InfoPlistGenerator { | |||
| Default info plist attributes taken from: | |||
| /Applications/Xcode.app/Contents/Developer/Library/Xcode/Templates/Project Templates/Base/Base_DefinitionsInfoPlist.xctemplate/TemplateInfo.plist | |||
| */ | |||
| var defaultInfoPlist: [String: Any] = { | |||
| private func generateDefaultInfoPlist(target: Target) -> [String: Any] { | |||
There was a problem hiding this comment.
According to the naming guideline, I prefer to be more grammatical name like generateDefaultInfoPlist(for:)
giginet
reviewed
Oct 22, 2019
| expectedInfoPlist["CFBundleDevelopmentRegion"] = "$(DEVELOPMENT_LANGUAGE)" | ||
| expectedInfoPlist["CFBundleShortVersionString"] = "1.0" | ||
| expectedInfoPlist["CFBundleVersion"] = "1" | ||
| expectedInfoPlist["CFBundlePackageType"] = "BNDL" |
There was a problem hiding this comment.
You can make it be immutable variable.
let expectedInfoPlist: [String: Any] = [
"CFBundleIdentifier": "$(PRODUCT_BUNDLE_IDENTIFIER)",
// ...
]
giginet
reviewed
Oct 22, 2019
| dictionary["CFBundleName"] = "$(PRODUCT_NAME)" | ||
| dictionary["CFBundleDevelopmentRegion"] = "$(DEVELOPMENT_LANGUAGE)" | ||
| dictionary["CFBundleShortVersionString"] = "1.0" | ||
| dictionary["CFBundleVersion"] = "1" | ||
|
|
||
| // Bundles should not contain any CFBundleExecutable otherwise they will be rejected when uploading. |
There was a problem hiding this comment.
Could you update ProjectSpec documentation too?
https://github.com/yonaskolb/XcodeGen/blob/master/Docs/ProjectSpec.md#target
The following properties are generated automatically
|
@giginet Thanks for your review, I addressed your comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When declaring a target like this
The generated Info.plist file contains a key
CFBundleExecutableby default. This key indicates that the bundle has a executable. When uploading an application with such a bundle that contains the Info.plist AppStore connect will decline the binary since a bundle by default doesn't contain any executable but rather only resources. Therefore, I suggest we do not generate theCFBundleExecutableby default for targets of typebundle.