Support optional include #712
Conversation
| $0.context("with optional include for non exist subspecs") { | ||
| $0.it("ignore subspecs") { | ||
| let path = fixturePath + "optional_include/optional_include.yml" | ||
| let project = try XCTUnwrap(loadSpec(path: path)) |
There was a problem hiding this comment.
XCTUnwrap will work only on Swift 5.1 or above.
There was a problem hiding this comment.
Can you use the new unwrap function from recently merged #714
| $0.context("with optional include for non exist subspecs") { | ||
| $0.it("ignore subspecs") { | ||
| let path = fixturePath + "optional_include/optional_include.yml" | ||
| let project = try XCTUnwrap(loadSpec(path: path)) |
There was a problem hiding this comment.
Can you use the new unwrap function from recently merged #714
Sources/ProjectSpec/SpecFile.swift
Outdated
| return try SpecFile(include: include, basePath: basePath, relativePath: relativePath) | ||
| } catch { | ||
| if include.optional { | ||
| return nil |
There was a problem hiding this comment.
This would make an optional includes silently fail if there was a different error than simply a missing file, for example if one of the includes own includes was missing. Is that the intention? Maybe it's better to only return nil if the file is actually missing
There was a problem hiding this comment.
Maybe it's better to only return nil if the file is actually missing
Do you mean optional should ignore throwing from try path.read() ?
|
@yonaskolb Following your comments I implemented a new strategy to cause errors. However, prior implementation seems to be simpler... |
| do { | ||
| data = try path.read() | ||
| } catch { | ||
| if shouldIgnoreNotFound { |
There was a problem hiding this comment.
I was thinking throwing a GenerationError.includeNotFound, which you can then catch at the top level, and it it's not optional then rethrow
Motivation
I want to add targets dynamically. including subspecs help me in the situation.
The included spec is automatically generated and if not exists ignore adding targets.
Description
I added
optionaloption toInclude.This value indicates whether ignoring failure loading (e.g. the path does not exist).