Fix localized *.intentdefinition have to be added to build source phases #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giginet
changed the title
giginet
commented
Nov 18, 2019
| path: filePath, | ||
| fileReference: variantGroup, | ||
| buildFile: PBXBuildFile(file: variantGroup), | ||
| buildPhase: .resources |
There was a problem hiding this comment.
Previous implementation, all files under *.lproj are treated as Resources. However, they should be generated by generateSourceFile function.
giginet
changed the title
|
Note that depending on what type of intents you're setting up you may prefer this to be in the resources phase and not the compile sources phase because you may not want generated code from this. |
|
If you want to treat them as Resources, you can specify sources:
- path: Sources/Intents.intentdefinition
buildPhase: resources |
brentleyjones
approved these changes
Nov 18, 2019
|
Thanks! |
yonaskolb
reviewed
Nov 19, 2019
| @@ -11,6 +11,7 @@ | |||
| - Improved variable expansion runtime [#704](https://github.com/yonaskolb/XcodeGen/pull/704) @rcari | |||
| - Fixed missing headers for static framework targets [#705](https://github.com/yonaskolb/XcodeGen/pull/705) @wag-miles | |||
| - Using more file types from XcodeProj for PBXFileReferences resulting in less project diffs [#715](https://github.com/yonaskolb/XcodeGen/pull/715) @yonaskolb | |||
| - Fixed localized *.intentdefinition have to be added to build source phases [#720](https://github.com/yonaskolb/XcodeGen/pull/720) @giginet | |||
There was a problem hiding this comment.
This * can make anything following render incorrectly in Markdown. Please wrap in `
| @@ -81,8 +81,8 @@ class SourceGenerator { | |||
| _ = try getSourceFiles(targetType: .none, targetSource: TargetSource(path: path), path: fullPath) | |||
| } | |||
|
|
|||
| func generateSourceFile(targetType: PBXProductType, targetSource: TargetSource, path: Path, buildPhase: TargetSource.BuildPhase? = nil) -> SourceFile { | |||
| let fileReference = fileReferencesByPath[path.string.lowercased()]! | |||
| func generateSourceFile(targetType: PBXProductType, targetSource: TargetSource, path: Path, buildPhase: TargetSource.BuildPhase? = nil, fileRefenrece: PBXFileElement? = nil) -> SourceFile { | |||
|
Nicely done @giginet! Looking forward to seeing this in an upcoming release! 🚀 |
|
The above comments have been resolved on master 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
localised .intentdefinition to sources does not work · Issue #614 · yonaskolb/XcodeGen
closes #614
Problem
In the situation, the project has localized
*.intentdefinition, they have to be added toCopy Bundle Resourcesphase instead ofCompile Sourcesphase.Description
Localized
*.intentdefinitionshould beSources. However, the current implementation treats asResources.This PR makes the issue to fix.