Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for language and region settings for target schemes #728

Conversation

FranzBusch
Copy link
Contributor

In Xcode it is possible to set the language and region that is used during running and testing the application. At the moment, this is only possible to set in XcodeGen for schemes but not for target schemes. This PR adds support to configure language and region on a target basis.

I opted to use the passed language and region for both the run and test action. Is this okay @yonaskolb? We can also separate this but this would require to add more parameters or change the TargetScheme API.

@FranzBusch FranzBusch force-pushed the feature/language-and-region-for-target-schemes branch 2 times, most recently from 3101dab to 5a1b15e Compare November 25, 2019 19:40
Copy link
Owner

@yonaskolb yonaskolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @FranzBusch! I just left some very minor comments

Sources/XcodeGenKit/SchemeGenerator.swift Show resolved Hide resolved
Docs/ProjectSpec.md Show resolved Hide resolved
Docs/ProjectSpec.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@FranzBusch
Copy link
Contributor Author

@yonaskolb Thanks for reviewing, please check it again when you find the time :)

@yonaskolb
Copy link
Owner

Thanks @FranzBusch. I released a new version yesterday, so you’ll just have to rebase your branch and move the changelog entry under the next version, sorry!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@FranzBusch FranzBusch force-pushed the feature/language-and-region-for-target-schemes branch from 3fcf7a4 to bedbfef Compare December 4, 2019 08:36
@FranzBusch
Copy link
Contributor Author

@yonaskolb done :)

@yonaskolb yonaskolb merged commit 99ce87d into yonaskolb:master Dec 4, 2019
@FranzBusch FranzBusch deleted the feature/language-and-region-for-target-schemes branch December 5, 2019 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants