Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to generate only plist files #739

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

namolnad
Copy link
Contributor

At Instacart we use XcodeGen in conjunction with Bazel. For one of our CI testing steps, we need only to generate the Plist files, and not the project in its entirety. This adds the option to exit early from the project generation command, after only generating the plist files.

@yonaskolb
Copy link
Owner

Interesting. Is not having this a performance issue for you? Theoretically you could generate a project with a name like Temp.xcodeproj and then run the following in your script:

xcodegen generate
rm -r Temp.xcodeproj

I can see the advantage of having this option though for simplicity

CHANGELOG.md Outdated Show resolved Hide resolved
@namolnad
Copy link
Contributor Author

namolnad commented Jan 7, 2020

@yonaskolb, it would be completely a convenience/simplicity thing for us. I just found myself thinking it would be a nice feature to have so thought I'd check on what it would take to add. (Turned out to be remarkably simple)

PS XcodeGen has been awesome and saving us so many headaches since we adopted it — so thanks for all your work on it!

@yonaskolb
Copy link
Owner

Cool, happy to add it. One thing though is that the SwiftCLI has been upgraded in the meantime so you’ll have to rebase and use the new property wrapper for the Flag

@namolnad namolnad force-pushed the plist-generation-only branch from 9fe36b4 to 03b0bf3 Compare January 7, 2020 21:46
Add changelog entry

Update CHANGELOG.md

Co-Authored-By: Yonas Kolb <yonaskolb@users.noreply.github.com>

Update to new flag PropertyWrapper
@namolnad namolnad force-pushed the plist-generation-only branch from 03b0bf3 to 0c6dd14 Compare January 7, 2020 21:49
@namolnad
Copy link
Contributor Author

namolnad commented Jan 7, 2020

sounds good, thanks for the heads up @yonaskolb! (After a quick bad rebase,) I think we should be g2g now. Thanks again for taking a look at this!

@yonaskolb yonaskolb merged commit 44f7e27 into yonaskolb:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants