Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace projectReference.path as relativePath #740

Merged
merged 5 commits into from
Jan 6, 2020
Merged

Replace projectReference.path as relativePath #740

merged 5 commits into from
Jan 6, 2020

Conversation

kateinoigakukun
Copy link
Collaborator

@kateinoigakukun kateinoigakukun commented Dec 18, 2019 •
edited
Loading

Fix #729

@kateinoigakukun kateinoigakukun mentioned this pull request Dec 18, 2019
Closed
@yonaskolb
Copy link
Owner

There is a test somewhere that validates that all the relevant relative paths are updated. Could you add this case to it as well?

@kateinoigakukun kateinoigakukun marked this pull request as ready for review January 6, 2020 11:52
@kateinoigakukun kateinoigakukun force-pushed the katei/resolve-proj-ref-relative branch from c1ef627 to c9fbd3a Compare January 6, 2020 11:58
@yonaskolb yonaskolb merged commit 058e084 into yonaskolb:master Jan 6, 2020
@PycKamil PycKamil mentioned this pull request Jan 7, 2020
Merged
@yonaskolb yonaskolb mentioned this pull request Jan 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonaskolb yonaskolb yonaskolb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

projectReferences path is not resolved correctly
2 participants
@kateinoigakukun @yonaskolb