Add spec validation for scheme test targets and tweak docs #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Scheme.Test action. Add additional coverate to ProjectSpectTests
…n target reference definitions
liamnichols
force-pushed
the
ln/scheme-target-validation
branch
from
c086a6c to
5a8bdc8
Compare
liamnichols
force-pushed
the
ln/scheme-target-validation
branch
from
5a8bdc8 to
6a33ad8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we roll out XcodeGen on our project, I got stumped for a little while when trying to create a Scheme definition that includes targets from a referenced project (and not a target defined in the spec).
It wasn't immediately obvious to me that I needed to use the
ProjectName/TargetNamesyntax for this to work since in Xcode, the GUI doesn't expose the fact that it does this for you.. After I figured that out, I decided to update the docs to include theFooLib/FooTargetexample previously used in the document to hopefully help anybody facing a similar situation in the future.After I made the changes and run the generator, I then hit a thrown exception with a different error that threw me off again until I debugged slightly to realise that the SpecValidation wasn't checking target references defined in the Test action (I'd only updated the build action)... To help make this a bit more obvious, I've expanded the validator to check the test actions target references as well as coverage target references in a similar way to how the build targets were being validated.
Thanks again for the great work so far! 🚀