Fix #784 Swift Package Manager (Embed & Sign) for dynamic packages.

[alexruperez]

Swift Package Manager dynamic dependencies declared like:

.library(name: "MyLib", type: .dynamic, targets: ["MyLib"])

Are embedded (Embed & Sign or Embed Without Signing if codeSign: false) when you declare embed: true in package dependency definition:

And included here:

[JesusMartinAlonso]

It would be great if this PR could be approved soon! Thanks @alexruperez for the contribution! :)

[brentleyjones]

@alexruperez Thanks for the fix! Can you update the tests and include the updated test fixtures as well? Also, can you add a Changelog entry?

[ghost]

great work @alexruperez :) thanks for taking time to fix it..

[yonaskolb]

Thanks for the PR @alexruperez!
Currently this PR embeds all Swift packages by default which is not I think what we want. You can see this in the test failure. We either need a way to tell if a package library is static or dynamic, or only embed if it’s been defined explicitly in the spec. The current embed property defaults to yes for application targets as can be seen above your change. We can create our own property for swift package dependencies that defaults to false

 let embed = dependency.embed ?? false

Why do you think? I more thorough solution would be to check the framework itself for a good default.

In addition could you please:

• add a changelog entry
• add a package with an embedded dynamic library to the SPM fixture https://github.com/yonaskolb/XcodeGen/blob/master/Tests/Fixtures/SPM/project.yml
• run the tests and check in the updated generated fixtures
• ideally we’d have a unit test for this too if you have the time

Thanks!

[alexruperez]

Thanks for the feedback @yonaskolb. Added changelog entry and fixtures updates.

Also SPM dependencies are embedded only when embed: true is declared in the project.yml

Does this fit for you?

[yonaskolb]

Thanks @alexruperez! Looks good!

[yonaskolb]

Released in 2.14.0