Use remote-runnable launch actions for Apple Watch schemes #798
Conversation
|
@yonaskolb Let me know if there are any changes you think need to be made, stylistic or otherwise. |
daltonclaybrook
force-pushed
the
watch-app-scheme
branch
from
fc768d2 to
2761120
Compare
|
@yonaskolb Is there any interest in getting this bug fixed? My team at Peloton has recently started using XcodeGen and we're loving it ❤️, but we currently have a hack-fix in place for this issue in particular. If this is not the best approach, please let me know. |
|
|
||
| $0.it("generates scheme with remote runnable for watch") { | ||
| let xcscheme = try self.makeWatchScheme(appType: .watch2App, extensionType: .watch2Extension) | ||
| try expect(xcscheme.launchAction?.runnable).beOfType(XCScheme.RemoteRunnable.self) |
There was a problem hiding this comment.
Can you add the opposite check elsewhere? To ensure we only make it a RemoteRunnable in this case, and a BuildableProductRunnable elsewhere?
|
@daltonclaybrook Did you encounter this issue with a standalone watch app? When debugging my schemes, I also noticed the difference between Xcode and XcodeGen regarding |
|
@tschob I tested this fix with a companion watch app. I will try to test again soon now that it's merged. |
Resolves #736
This PR fixes an issue that prevents a Watch app from being launched using the generated scheme. The
BuildableProductRunnablelaunch action has been replaced with aRemoteRunnableaction, and the host app has been added as aBuildActionEntry. This more closely matches the scheme that Xcode generates when creating a new Apple Watch app target and seems to work correctly when building/running the target from Xcode.