Add improved support for simple iOS sticker packs #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, simple iOS sticker packs created in Xcode do not include a compile sources phase. This change will allow messages applications with an empty list of sources to skip that phase entirely.
This is especially important for simple iOS sticker packs that require this run scheme setting to be set to 2 in order to run the scheme properly.
|
Thanks @scelis! Can you add |
|
@brentleyjones Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of updating some of our iOS sticker packs to use XcodeGen, I ran into two issues:
By default, messages applications for simple iOS sticker packs created in Xcode do not include a compile sources phase. While XcodeGen supports this for the sticker pack extension, it does not for the messages application itself. The first commit in this PR addresses this issue and allows the target to skip the compile sources phase if the application has no sources.
In order for the run scheme to function properly,
launchAutomaticallySubstylemust be set to 2. Doing so will change the executable dropdown from the sticker app toAsk on Launch. Without this change, running the scheme will cause the simulator to open but hang instead of launching Messages.The second commit in this PR addresses that issue and updates the TestProject fixture which needed to be changed.
Since none of this is obvious, I added an example project for a simple sticker pack to
Examples.md.