Fix handling of SWIFT_INSTALL_OBJC_HEADER when its value is YES/NO. #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. @yonaskolb Do you think we need to keep true/false literal compatibility that is invalid value on Xcode? |
ileitch
force-pushed
the
fix-SWIFT_INSTALL_OBJC_HEADER
branch
from
3c27dc1 to
8b24d99
Compare
yonaskolb
reviewed
Apr 13, 2020
There was a problem hiding this comment.
Thanks @ileitch!
Yeah we probably don't need to maintain compatibility with true/false for this one specific case. Having said that it might be useful to have a wrapper around getCombinedBuildSetting called getBoolBuildSetting which checks for YES/NO and true/false. That could be used here if you'd like to add it @ileitch
| let swiftInstallObjCHeader = project.getCombinedBuildSetting("SWIFT_INSTALL_OBJC_HEADER", target: target, config: project.configs[0]) as? Bool | ||
| let swiftInstallObjCHeaderValue = project.getCombinedBuildSetting("SWIFT_INSTALL_OBJC_HEADER", target: target, config: project.configs[0]) | ||
|
|
||
| var swiftInstallObjCHeader = true // Xcode default |
There was a problem hiding this comment.
Now that this is a non optional, can we update the confusing line below
&& swiftInstallObjCHeader != falseto just:
&& swiftInstallObjCHeader
ileitch
force-pushed
the
fix-SWIFT_INSTALL_OBJC_HEADER
branch
from
8b24d99 to
c3ecf4a
Compare
yonaskolb
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if true/false literals are valid values for xcconfig, but I guess we'll need to continue supporting it for backwards compatibility.
For reference: #805
/cc @kateinoigakukun