Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically include bundles in the Copy Bundle Resources build phase #838

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Automatically include bundles in the Copy Bundle Resources build phase #838

merged 2 commits into from
Apr 22, 2020

Conversation

skirchmeier
Copy link
Contributor

This PR fixes a regression introduced in #826. In previous versions, bundles were implicitly included in the Copy Bundle Resources build phase. The regression omitted bundle from the allowed list, but tests were passing since the target files were added explicitly.

Copy link
Collaborator

@brentleyjones brentleyjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @skirchmeier 😸

@brentleyjones brentleyjones merged commit aeb6596 into yonaskolb:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants