Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate correct PBXTargetDependency for external targets. #843

Merged
merged 2 commits into from
Apr 23, 2020
Merged

Generate correct PBXTargetDependency for external targets. #843

merged 2 commits into from
Apr 23, 2020

Conversation

ileitch
Copy link
Contributor

@ileitch ileitch commented Apr 23, 2020

Xcode does not include the target attribute on PBXTargetDependency for external targets, but instead includes the name.

This also resolves warnings output by CocoaPods, e.g:

[!] `<PBXTargetDependency UUID=`C445C9EFB768C6946E0137E9`>` attempted to initialize an object with an unknown UUID. `81DE8F467B21B81B5BEEE6B2` for attribute: `target`. This can be the result of a merge and the unknown UUID is being discarded.

@brentleyjones brentleyjones merged commit f010771 into yonaskolb:master Apr 23, 2020
@ileitch ileitch deleted the external-target branch April 23, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentleyjones brentleyjones brentleyjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ileitch @brentleyjones