-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to xcproj 0.4.0 #85
Conversation
Thanks @enmiller! The tests will need to be updated as well 👍 |
Two things needed to be done to get the tests to pass again:
self.projectRoot = try container.decode(.projectRoot) and I had to change it to self.projectRoot = try container.decodeIfPresent(.projectRoot) The reason being that both /* Begin PBXProject section */
...
projectRoot = "";
...
/* End PBXProject section */ The decoder seems to be evaluating this to I'll open a PR with Edit |
Here is the console error for the test failure related to
|
Hey @enmiller it was my fault. I'll make a new release today, 0.4.1, that includes that fix, and brings back the |
@enmiller, could update to 0.4.1 in this PR, and then run the tests to update the generated fixtures |
"revision": "5ac9248b378b5e12201c255ba74caf990d1e0f4b", | ||
"version": "0.3.6" | ||
"revision": "05921531200acff0d8d9caab5ec77b2bcf300b6b", | ||
"version": "0.3.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't stop this from updating (still a little new to the SwiftPM). After looking at the Yams repo, it doesn't appear much changed from 0.3.6
to 0.3.7
that would impact XcodeGen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine
No description provided.