Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds uncluttering dumped YAML manifest from nil entries. #858

Merged
merged 3 commits into from
May 11, 2020

Conversation

maciejpiotrowski89
Copy link
Contributor

Problem

When a manifest is read from a disk, modified and dumped back to the disk it contains null entires, empty dictionaries and arrays:

name: MyProject
options:
  bundleIdPrefix: null
  carthageBuildPath: null
  carthageExecutablePath: null
  defaultConfig: null
  deploymentTarget:
    iOS: null
    macOS: null
    tvOS: null
    watchOS: null
  developmentLanguage: null
  disabledValidations: []
  groupSortPosition: bottom
  indentWidth: null
  localPackagesGroup: null
  minimumXcodeGenVersion: null
  postGenCommand: null
  preGenCommand: null
  tabWidth: null
  transitivelyLinkDependencies: false
  usesTabs: null
  xcodeVersion: null
packages: {}
projectReferences: {}
# ...

What

This PR adds uncluttering of a dictionary from nil and empty entires so that dumped YAML contains only meaningful contents.

@yonaskolb
Copy link
Owner

Great, thanks @paciej00! Could you add a changelog entry as well?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@maciejpiotrowski89
Copy link
Contributor Author

Sure thing, I updated the changelog :)

@yonaskolb yonaskolb merged commit 4d6e63e into yonaskolb:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants