-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to name the executable target in schemes. #866
Added ability to name the executable target in schemes. #866
Conversation
``` schemes: MyScheme: build: executable: MyExecutable targets: ... ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good PR we need this 👌 💯
Can you add a changelog entry? Thanks. |
Thanks @elland! |
Hi @elland, thanks for the PR! I think this got merged a bit prematurely though. As you say this property makes more sense on |
My bad for not catching that 😬. Thanks @yonaskolb 😄. |
@yonaskolb yes, but I couldn't really figure out how to do it via |
@elland great thanks! Was there a specific issue you were hitting when adding it to Run? If I'm not mistaken the property should be able to be stored, decoded and read just the same from |
@yonaskolb, I think when I tried that I lacked a bit more understanding of the code, I think I'll manage the second time around :) |
``` schemes: MyScheme: build: executable: MyExecutable targets: ... ```
Attempting to address #589. I only managed to gather a small understanding of the code base, so please let me know if there's a simpler/better way of doing this. For example, I don't like that I'm using a value from the
build
section to configure something in therun
section.It works by adding the
executable
key to thebuild
subsection of a scheme: