Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to name the executable target in schemes. #866

Merged

Conversation

elland
Copy link
Contributor

@elland elland commented May 19, 2020

Attempting to address #589. I only managed to gather a small understanding of the code base, so please let me know if there's a simpler/better way of doing this. For example, I don't like that I'm using a value from the build section to configure something in the run section.

It works by adding the executable key to the build subsection of a scheme:

schemes:
  MyScheme:
    build:
      executable: MyExecutable
      targets:
      ...

Igor Ranieri Elland added 2 commits May 19, 2020 13:11
```
schemes:
  MyScheme:
    build:
      executable: MyExecutable
      targets:
      ...
```
Copy link

@BilalReffas BilalReffas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR we need this 👌 💯

@brentleyjones
Copy link
Collaborator

Can you add a changelog entry? Thanks.

@elland
Copy link
Contributor Author

elland commented May 20, 2020

@brentleyjones

@brentleyjones
Copy link
Collaborator

Thanks @elland!

@brentleyjones brentleyjones merged commit 92aaebb into yonaskolb:master May 20, 2020
@yonaskolb
Copy link
Owner

Hi @elland, thanks for the PR! I think this got merged a bit prematurely though. As you say this property makes more sense on run instead of build. Could you please make a new PR for this, and also update the docs at https://github.com/yonaskolb/XcodeGen/blob/master/Docs/ProjectSpec.md#scheme

@brentleyjones
Copy link
Collaborator

My bad for not catching that 😬. Thanks @yonaskolb 😄.

@elland
Copy link
Contributor Author

elland commented May 20, 2020

@yonaskolb yes, but I couldn't really figure out how to do it via run yet. I can try again when I get back to work next week. (It's a 4 day weekend here in Germany)

@yonaskolb
Copy link
Owner

@elland great thanks! Was there a specific issue you were hitting when adding it to Run? If I'm not mistaken the property should be able to be stored, decoded and read just the same from Build's sibling struct Run instead. But let me know if there's an issue with that 👍

@elland
Copy link
Contributor Author

elland commented May 25, 2020

@yonaskolb, I think when I tried that I lacked a bit more understanding of the code, I think I'll manage the second time around :)

elland added a commit to elland/XcodeGen that referenced this pull request May 28, 2020
```
schemes:
  MyScheme:
    build:
      executable: MyExecutable
      targets:
      ...
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants