Implement document detail page #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. It's still in draft, but I'll leave a brief comment. The detail page can be accessed from the list, but the user can also directly access the URL. We need to handle the case when the user directly opens the project details page as well. |
Before, the snapshot data only passed when users clicked the link. Implement to fetch data when the DocumentDetail component is mounted to show the document data when entering the URL directly. This commit also adds some codes by pasting the grpc protocol. (to keep a single source of truth) - Add project list command - Remove collection from document - Rename agent to server - Rename `db` package to `database` Co-authored-by: Youngteac Hong <youngteac.hong@navercorp.com>
|
@chacha912 |
hackerwins
approved these changes
May 7, 2022
| unknown, | ||
| Action<string> | ||
| >; | ||
| export type AppThunk<ReturnType = void> = ThunkAction<ReturnType, RootState, unknown, Action<string>>; |
There was a problem hiding this comment.
As you said, It would be good to introduce prettier.
https://create-react-app.dev/docs/setting-up-your-editor/#formatting-code-automatically
hackerwins
added a commit
that referenced
this pull request
May 7, 2022
Fetch document data when the DocumentDetail component is mounted. Before, the snapshot data only passed when users clicked the link. Implement to fetch data when the DocumentDetail component is mounted to show the document data when entering the URL directly. This commit also adds some codes by pasting the grpc protocol. (to keep a single source of truth) - Add project list command - Remove collection from document - Rename agent to server - Rename `db` package to `database` Co-authored-by: Youngteac Hong <youngteac.hong@navercorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
The document detail page is shown when the user selects a document from the document list page.
Users can see snapshots of the document on the document detail page.
The user can access the document again using the URL of a specific document.
/documents/documents/{documentId}TODO
/projects/{proiectID}/documents/{documentKey}Isolate clients and documents for each project yorkie#319Any background context you want to provide?
What are the relevant tickets?
Fixes #9
Checklist