Add customizable metadata for peer awareness #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackerwins
force-pushed
the
master
branch
3 times, most recently
from
95c4477 to
30bbef2
Compare
|
We will continue this at #123. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add customizable metadata for peer awareness. Currently the API only exposes client ID and there's no way to add extra information about the client during collaborative activities.
How should this be manually tested?
Any background context you want to provide?
This works around
WatchDocumentsrpc call. In theWatchDocumentsRequestI add a new meta field, where you could put whatever peer's metadata there. The metadata then passed along with theWatchDocumentsResponse.What are the relevant tickets?
Fixes #106
Related with yorkie-team/yorkie#48
Checklist