-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RemoveDocument API #480
Conversation
Codecov Report
@@ Coverage Diff @@
## main #480 +/- ##
==========================================
+ Coverage 89.57% 89.68% +0.11%
==========================================
Files 67 67
Lines 5410 5596 +186
Branches 528 542 +14
==========================================
+ Hits 4846 5019 +173
- Misses 381 386 +5
- Partials 183 191 +8
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
Overall good. I left a few questions.
Co-authored-by: Youngteac Hong <susukang98@gmail.com>
What this PR does / why we need it?
What are the relevant tickets?
Ref: yorkie-team/yorkie#484
Ref: yorkie-team/yorkie#491
Does this PR introduce a user-facing change?:
The new approach is to establish a stream connection for each document
instead of watching multiple documents on a single stream.
As a result, the issue of disconnecting and reconnecting the stream
when multiple documents are attached has been resolved.
Consequently, the client events that were tested have also been modified as shown below.
The event marked in red does not occur. - Refer to #484 for the previous test flow
Checklist