Support multi-user undo and redo #635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yourim Cha <yourim.cha@navercorp.com>
Co-authored-by: Yourim Cha <yourim.cha@navercorp.com>
Co-authored-by: Yourim Cha <yourim.cha@navercorp.com>
|
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
==========================================
- Coverage 88.88% 87.62% -1.26%
==========================================
Files 80 81 +1
Lines 8958 9747 +789
Branches 825 875 +50
==========================================
+ Hits 7962 8541 +579
- Misses 688 885 +197
- Partials 308 321 +13
☔ View full report in Codecov by Sentry. |
…yorkie-js-sdk into feat/undo-redo-arch
…yorkie-js-sdk into feat/undo-redo-arch
…nto feat/undo-redo-arch
…yorkie-js-sdk into feat/undo-redo-arch
2 tasks
2 tasks
2 tasks
Currently, executedAt is used as createdAt, preventing the creation of elements with same createdAt. To enable creating elements with same createdAt during undo, this commit introduced lastUpdatedAt and compared it to executedAt.
…yorkie-js-sdk into feat/undo-redo-arch
…nto feat/undo-redo-arch
chacha912
force-pushed
the
feat/undo-redo-arch
branch
from
336daaa to
fd6ae03
Compare
5 tasks
|
This continued in #650. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
It's the initial version of multi-user undo/redo implementation. For now, it's focusing on implementing an architecture to support undo/redo using
liveblocksas a reference.Any background context you want to provide?
Additional information about multi-user undo/redo is at yorkie-team/yorkie#49.
What are the relevant tickets?
Fixes #
Checklist