-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tree.move #638
Add Tree.move #638
Conversation
…nto implement-undo-do-redo-and-tree-move
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #638 +/- ##
===========================================
+ Coverage 71.38% 88.32% +16.93%
===========================================
Files 58 81 +23
Lines 8734 9206 +472
Branches 784 870 +86
===========================================
+ Hits 6235 8131 +1896
+ Misses 2241 747 -1494
- Partials 258 328 +70
☔ View full report in Codecov by Sentry. |
traverseInPosRange does not guarantee the undoEdit, because it's using alive children's indexes, therefore add new method to traverse between nodes whether they're removed or not
…nto implement-undo-do-redo-and-tree-move
a9325d6
to
7baa69f
Compare
I will close this PR for now. Please let me know when you proceed. |
What this PR does / why we need it?
Add Tree.move.
Any background context you want to provide?
please read yorkie-team/yorkie#634
What are the relevant tickets?
Fixes yorkie-team/yorkie#634
Checklist