Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tree.move #638

Closed
wants to merge 33 commits into from
Closed

Add Tree.move #638

wants to merge 33 commits into from

Conversation

JOOHOJANG
Copy link
Contributor

@JOOHOJANG JOOHOJANG commented Sep 1, 2023

What this PR does / why we need it?

Add Tree.move.

  • Define reverse edit operation
  • Add operation log
  • Define do, undo
  • Define reverse style operation
  • Define move operation and reverse move operation
  • Find difference between prev and current tree, make changes

Any background context you want to provide?

please read yorkie-team/yorkie#634

What are the relevant tickets?

Fixes yorkie-team/yorkie#634

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Attention: 90 lines in your changes are missing coverage. Please review.

Comparison is base (c4938f7) 71.38% compared to head (8c74057) 88.32%.
Report is 7 commits behind head on main.

❗ Current head 8c74057 differs from pull request most recent head c259720. Consider uploading reports for the commit c259720 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #638       +/-   ##
===========================================
+ Coverage   71.38%   88.32%   +16.93%     
===========================================
  Files          58       81       +23     
  Lines        8734     9206      +472     
  Branches      784      870       +86     
===========================================
+ Hits         6235     8131     +1896     
+ Misses       2241      747     -1494     
- Partials      258      328       +70     
Files Coverage Δ
src/util/array.ts 100.00% <100.00%> (ø)
test/unit/document/crdt/tree_test.ts 46.69% <100.00%> (ø)
src/document/crdt/rht.ts 97.29% <0.00%> (-2.71%) ⬇️
src/document/json/tree.ts 54.80% <0.00%> (-4.13%) ⬇️
src/document/crdt/tree.ts 76.36% <68.44%> (-8.39%) ⬇️

... and 55 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hackerwins hackerwins force-pushed the main branch 2 times, most recently from a9325d6 to 7baa69f Compare October 20, 2023 07:46
@hackerwins
Copy link
Member

I will close this PR for now. Please let me know when you proceed.

@hackerwins hackerwins closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Tree.move
2 participants