Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dropping node 16 support #653

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Conversation

blurfx
Copy link
Member

@blurfx blurfx commented Sep 23, 2023

What this PR does / why we need it?

Drop node.js 16 supports due to node.js 16 is deprecated since 11st Sep, 2023.

Any background context you want to provide?

https://nodejs.org/en/blog/announcements/nodejs16-eol

https://nodejs.dev/en/about/releases/

What are the relevant tickets?

Fixes #652

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@blurfx blurfx self-assigned this Sep 23, 2023
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03% 🎉

Comparison is base (b86d963) 88.77% compared to head (2ab98f5) 88.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
+ Coverage   88.77%   88.80%   +0.03%     
==========================================
  Files          78       78              
  Lines        8899     8899              
  Branches      821      821              
==========================================
+ Hits         7900     7903       +3     
+ Misses        691      688       -3     
  Partials      308      308              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hackerwins hackerwins self-requested a review September 23, 2023 07:46
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 795cd30 into yorkie-team:main Sep 23, 2023
1 check passed
@blurfx blurfx deleted the feat/drop-node16 branch September 23, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropping node.js 16 support
2 participants