Avoid unnecessary syncs in push-only syncmode #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #818 +/- ##
=======================================
Coverage 80.76% 80.77%
=======================================
Files 59 59
Lines 4534 4536 +2
Branches 916 917 +1
=======================================
+ Hits 3662 3664 +2
Misses 608 608
Partials 264 264 ☔ View full report in Codecov by Sentry. |
hackerwins
approved these changes
May 23, 2024
hackerwins
pushed a commit
that referenced
this pull request
May 23, 2024
When syncmode is set to pushonly and there are no local changes, sync requests should not be triggered by remote changes.
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
When syncmode is set to pushonly and there are no local changes, sync requests should not be triggered by remote changes.
Any background context you want to provide?
What are the relevant tickets?
Addresses #816
Checklist