Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Room from Document and move Presence from Client to Room #442

Closed
hackerwins opened this issue Jan 11, 2023 · 1 comment
Closed

Extract Room from Document and move Presence from Client to Room #442

hackerwins opened this issue Jan 11, 2023 · 1 comment
Assignees
@chacha912
Labels
enhancement 🌟 New feature or request sdk ⚒️

Comments

@hackerwins
Copy link
Member

Description:

Extract Room from Document and move Presence from Client to Room

AS-IS
Screenshot 2023-01-11 at 9 41 54 AM

TO-BE
Screenshot 2023-01-11 at 9 41 58 AM

Related to

Why:

  • Topics cannot be separated if a client attaches two different documents.
  • We can use transactions by combining the document and the presence. This can reduce the workload by representing Text's selection as presence because presence is cheaper than Document(CRDT).
This was referenced Jan 11, 2023
Closed
Closed
@chacha912 chacha912 mentioned this issue Jun 1, 2023
Closed
2 tasks
@chacha912 chacha912 mentioned this issue Jun 16, 2023
Closed
2 tasks
@hackerwins hackerwins mentioned this issue Jul 14, 2023
Closed
2 tasks
@chacha912 chacha912 mentioned this issue Jul 14, 2023
Merged
2 tasks
@hackerwins hackerwins added the enhancement 🌟 New feature or request label Jul 15, 2023
@chacha912 chacha912 mentioned this issue Jul 18, 2023
Merged
2 tasks
@chacha912 chacha912 mentioned this issue Aug 7, 2023
Open
@sejongk sejongk mentioned this issue Aug 25, 2023
Open
@hackerwins
Copy link
Member Author

Move Presence to Document

@github-project-automation github-project-automation bot moved this from Todo to Done in Yorkie Project Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chacha912 chacha912

Labels
enhancement 🌟 New feature or request sdk ⚒️
Projects
No open projects
Yorkie Project
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move Presence from Client to Document yorkie-team/yorkie
2 participants
@hackerwins @chacha912