-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Presence from Client to Document #574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #574 +/- ##
==========================================
+ Coverage 87.93% 88.19% +0.26%
==========================================
Files 79 81 +2
Lines 7807 7830 +23
Branches 780 799 +19
==========================================
+ Hits 6865 6906 +41
+ Misses 627 610 -17
+ Partials 315 314 -1
|
hackerwins
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
3 tasks
2 tasks
2 tasks
2 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Move Presence from Client to Document
Why?
yorkie-team/yorkie#442
presence
in text selection and drawing.initial presence
Instead of providing initial presence when creating the client,
the initial presence is now passed when creating the document.
subscribe peersChanged event
The
peers-changed
event has been moved from the client to the document.doc.getPeers()
Instead of retrieving peers from the client's perspective,
you can now get peers from the document.
What are the relevant tickets?
Related yorkie-team/yorkie#542, yorkie-team/yorkie#582
Checklist