-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a way to refresh token for Auth Webhook #996
Closed
Labels
Comments
@xet-a Seems like this issue is somewhat similar to your previous refresh token work on CodePair? |
I'm interested in this issue. Can I try this? |
@xet-a Assigned 😄 |
This was referenced Oct 17, 2024
hackerwins
added a commit
that referenced
this issue
Nov 1, 2024
This change enhances the webhook response format to provide more granular error handling while maintaining the existing response body structure {allowed: bool, reason: string}. The implementation adds standard HTTP status codes: - 200 OK: Request allowed - 401 Unauthorized: Invalid/missing token, indicating need for token refresh - 403 Forbidden: Valid token but insufficient permissions This distinction enables clients to better handle authentication vs authorization scenarios. A follow-up change will be needed to implement token refresh functionality (see #996). --------- Co-authored-by: Youngteac Hong <susukang98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description:
We have added the auth webhook feature in #188, which allows the
Client
to verify whether it has access rights to a specificDocument
. The current implementation only utilizes the initially provided token for authentication, and there is no functionality for token refresh once it expires.To enhance the user experience, I propose implementing a token refresh mechanism. This would involve two key components:
Related to #188 (comment)
Related to yorkie-team/codepair#160
Why:
Implementing this token refresh mechanism will ensure that users can maintain their sessions without interruptions, thereby providing a seamless and continuous experience while working with the Client.
The text was updated successfully, but these errors were encountered: