-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement in-memory DB to run Yorkie without MongoDB #276
Conversation
Codecov Report
@@ Coverage Diff @@
## main #276 +/- ##
==========================================
- Coverage 50.21% 49.94% -0.28%
==========================================
Files 53 54 +1
Lines 4375 4655 +280
==========================================
+ Hits 2197 2325 +128
- Misses 1966 2087 +121
- Partials 212 243 +31
Continue to review full report at Codecov.
|
66bb781
to
0f24aad
Compare
9652e6d
to
0d84941
Compare
I used MemoryDB for Rust SDK integration test. Response times were shorter than when using MongoDB.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing your awesome work! 👍
I have some questions and suggestions. Please check. 🙇
65104f5
to
4300cd9
Compare
What this PR does / why we need it:
If
mongo-connection-uri
flag is set when the Agent is running, MongoDB is used, otherwise MemDB is used.When using MemDB, Agent stores its data in memory, so stopping the server will lose all data.
Run Yorkie without MongoDB:
Run Yorkie with MongoDB:
Which issue(s) this PR fixes:
Fixes #275
Special notes for your reviewer:
This PR starts the Memory DB implementation. If we can't finish all in this PR, we can just merge this and wait for help from other contributors.Tasks:
Finally, implemented all DB interfaces in the memory version.
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: