Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ListDocuments API #309

Merged
merged 1 commit into from
Apr 17, 2022
Merged

Add ListDocuments API #309

merged 1 commit into from
Apr 17, 2022

Conversation

hackerwins
Copy link
Member

@hackerwins hackerwins commented Apr 12, 2022

What this PR does / why we need it:

Add ListDocuments API

  • Split yorkie.protobuf into separate files
  • Rename FetchHistory to ListChanges

Which issue(s) this PR fixes:

Address #273

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #309 (8eaef9f) into main (06a4479) will decrease coverage by 0.27%.
The diff coverage is 28.37%.

@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
- Coverage   48.33%   48.06%   -0.28%     
==========================================
  Files          59       60       +1     
  Lines        4837     4904      +67     
==========================================
+ Hits         2338     2357      +19     
- Misses       2240     2287      +47     
- Partials      259      260       +1     
Impacted Files Coverage Δ
api/converter/to_pb.go 80.37% <0.00%> (-2.19%) ⬇️
client/client.go 10.48% <0.00%> (ø)
pkg/document/internal_document.go 20.96% <0.00%> (-0.35%) ⬇️
yorkie/backend/db/mongo/client.go 0.00% <0.00%> (ø)
yorkie/rpc/yorkie_server.go 37.74% <0.00%> (ø)
yorkie/rpc/admin_server.go 14.28% <14.28%> (ø)
yorkie/backend/db/memory/db.go 50.00% <89.47%> (+2.16%) ⬆️
yorkie/rpc/server.go 66.66% <100.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06a4479...8eaef9f. Read the comment docs.

@hackerwins hackerwins marked this pull request as draft April 12, 2022 04:49
@hackerwins hackerwins marked this pull request as ready for review April 13, 2022 04:40
@hackerwins hackerwins requested a review from a team April 13, 2022 04:40
- Split yorkie.protobuf into separate files
- Rename FetchHistory to ListChanges
@hackerwins hackerwins merged commit 8022151 into main Apr 17, 2022
@hackerwins hackerwins deleted the admin-api branch April 17, 2022 10:02
jeonjonghyeok pushed a commit to jeonjonghyeok/yorkie that referenced this pull request Aug 4, 2022
- Split yorkie.protobuf into separate files
- Rename FetchHistory to ListChanges
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant