Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename agent to server #316

Merged
merged 1 commit into from
May 2, 2022
Merged

Rename agent to server #316

merged 1 commit into from
May 2, 2022

Conversation

hackerwins
Copy link
Member

@hackerwins hackerwins commented May 2, 2022

What this PR does / why we need it:

Rename agent to server

Initially, we wanted to install Yorkie on the nodes where MongoDB
is installed, so I named it Agent.

However, we implemented Agents like normal Servers, and the name
of Agent is confusing, so it would be better to rename it as Server.

Which issue(s) this PR fixes:

Fixes #260

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #316 (cbcf059) into main (653a12d) will not change coverage.
The diff coverage is 9.52%.

@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   46.80%   46.80%           
=======================================
  Files          58       58           
  Lines        5072     5072           
=======================================
  Hits         2374     2374           
  Misses       2443     2443           
  Partials      255      255           
Impacted Files Coverage Δ
api/converter/from_pb.go 61.55% <ø> (ø)
api/converter/to_pb.go 75.26% <ø> (ø)
client/client.go 11.19% <ø> (ø)
pkg/document/json/root.go 81.48% <ø> (ø)
server/backend/backend.go 0.00% <0.00%> (ø)
server/backend/config.go 61.29% <ø> (ø)
server/backend/db/change_info.go 29.16% <ø> (ø)
server/backend/db/client_info.go 39.62% <ø> (ø)
server/backend/db/doc_info.go 0.00% <ø> (ø)
server/backend/db/memory/db.go 45.92% <ø> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 653a12d...cbcf059. Read the comment docs.

@hackerwins hackerwins requested a review from a team May 2, 2022 05:18
Initially, we wanted to install Yorkie on the nodes where MongoDB
is installed, so I named it Agent.

However, we implemented Agents like normal Servers, and the name
of Agent is confusing, so it would be better to rename it as Server.
@hackerwins hackerwins force-pushed the rename-agent-to-server branch from c4531ac to cbcf059 Compare May 2, 2022 05:28
@hackerwins hackerwins merged commit d016530 into main May 2, 2022
@hackerwins hackerwins deleted the rename-agent-to-server branch May 2, 2022 05:36
hackerwins added a commit that referenced this pull request May 2, 2022
Initially, we had a plan to install Yorkie on the nodes where MongoDB
is installed, so we named it Agent.

However, we implemented Agents like normal Servers and the name
of Agent is confusing. So this commit renames it as Server.
jeonjonghyeok pushed a commit to jeonjonghyeok/yorkie that referenced this pull request Aug 4, 2022
Initially, we had a plan to install Yorkie on the nodes where MongoDB
is installed, so we named it Agent.

However, we implemented Agents like normal Servers and the name
of Agent is confusing. So this commit renames it as Server.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Agent to Server
1 participant