Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up Go to 1.19.2 #425

Merged
merged 3 commits into from
Oct 8, 2022
Merged

Bump up Go to 1.19.2 #425

merged 3 commits into from
Oct 8, 2022

Conversation

hackerwins
Copy link
Member

@hackerwins hackerwins commented Oct 8, 2022

What this PR does / why we need it:

Bump up Go to 1.19.2

In versions prior to 1.19.2, compile errors occurred due to issues with Generics.

golang/go#54225

Which issue(s) this PR fixes:

Fixes #378

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Merging #425 (257ca9b) into main (e96be59) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #425   +/-   ##
=======================================
  Coverage   46.86%   46.86%           
=======================================
  Files          71       71           
  Lines        5930     5930           
=======================================
  Hits         2779     2779           
  Misses       2846     2846           
  Partials      305      305           
Impacted Files Coverage Δ
api/types/id.go 0.00% <ø> (ø)
client/client.go 11.88% <ø> (ø)
pkg/cache/cache.go 100.00% <ø> (ø)
pkg/document/change/change.go 0.00% <ø> (ø)
pkg/document/crdt/root.go 80.00% <ø> (ø)
pkg/document/document.go 56.06% <ø> (ø)
pkg/document/time/ticket.go 89.18% <ø> (ø)
pkg/llrb/llrb.go 80.31% <ø> (ø)
pkg/pq/priority_queue.go 100.00% <ø> (ø)
pkg/splay/splay.go 77.08% <ø> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hackerwins hackerwins marked this pull request as ready for review October 8, 2022 10:59
@hackerwins hackerwins merged commit 3d3123f into main Oct 8, 2022
@hackerwins hackerwins deleted the go-1-19 branch October 8, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when building Docker images with Go 1.19
1 participant