Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock watchDocuments depending on the client and doc #506

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

chacha912
Copy link
Contributor

What this PR does / why we need it:

Since the client cannot wait for the watch stream to be disconnected,
add a lock to re-establish the watch stream after it has been disconnected.

Which issue(s) this PR fixes:

Related #479

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #506 (9454952) into main (bbd06b2) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
- Coverage   50.31%   50.22%   -0.10%     
==========================================
  Files          64       64              
  Lines        5660     5671      +11     
==========================================
  Hits         2848     2848              
- Misses       2470     2481      +11     
  Partials      342      342              
Impacted Files Coverage Δ
server/rpc/yorkie_server.go 37.30% <0.00%> (-1.30%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hackerwins hackerwins self-requested a review April 10, 2023 08:05
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 6a1132f into main Apr 10, 2023
@hackerwins hackerwins deleted the fix/watch-document branch April 10, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants