Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Initialization message to WatchDocumentsResponse #64

Merged
merged 1 commit into from
Jul 18, 2020

Conversation

hackerwins
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test

/kind feature

What this PR does / why we need it:

When multiple users edit a document, the user wants to know who is connected.

Which issue(s) this PR fixes:

Address #48

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


@hackerwins hackerwins added the wip label Jul 4, 2020
@hackerwins hackerwins force-pushed the feature/peer-awareness branch from 845cba5 to f07b15e Compare July 18, 2020 07:55
@codecov
Copy link

codecov bot commented Jul 18, 2020

Codecov Report

Merging #64 into master will decrease coverage by 0.11%.
The diff coverage is 1.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   54.03%   53.92%   -0.12%     
==========================================
  Files          23       23              
  Lines        2650     2663      +13     
==========================================
+ Hits         1432     1436       +4     
- Misses       1121     1130       +9     
  Partials       97       97              
Impacted Files Coverage Δ
api/converter/from_pb.go 77.27% <0.00%> (ø)
api/converter/to_pb.go 73.01% <0.00%> (-3.66%) ⬇️
pkg/splay/splay.go 47.75% <ø> (ø)
yorkie/rpc/rpc_server.go 43.04% <0.00%> (-0.77%) ⬇️
client/client.go 57.48% <100.00%> (ø)
pkg/llrb/llrb.go 76.19% <0.00%> (+2.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9ea57b...f07b15e. Read the comment docs.

@hackerwins hackerwins merged commit 7507523 into master Jul 18, 2020
@hackerwins hackerwins deleted the feature/peer-awareness branch July 18, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant