-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker compose command to V2 #950
Conversation
WalkthroughThe changes update the CI workflow and related documentation to replace Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/ci.yml (2 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/ci.yml
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #950 +/- ##
=======================================
Coverage 51.31% 51.31%
=======================================
Files 71 71
Lines 10679 10679
=======================================
Hits 5480 5480
Misses 4650 4650
Partials 549 549 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
build/docker/README.md (1)
8-8
: Add missing article for clarity.The sentence would be clearer with the addition of "the" before "docker compose command".
- through `docker compose` command. + through the `docker compose` command.Tools
LanguageTool
[uncategorized] ~8-~8: You might be missing the article “the” here.
Context: ...required dependant applications throughdocker compose
command. ```bash # Run ...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- CONTRIBUTING.md (1 hunks)
- build/docker/README.md (1 hunks)
Files skipped from review due to trivial changes (1)
- CONTRIBUTING.md
Additional context used
LanguageTool
build/docker/README.md
[uncategorized] ~8-~8: You might be missing the article “the” here.
Context: ...required dependant applications throughdocker compose
command. ```bash # Run ...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
Additional comments not posted (2)
build/docker/README.md (2)
12-12
: LGTM!The command syntax is correctly updated to
docker compose
.
15-15
: LGTM!The command syntax is correctly updated to
docker compose
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Update docker compose command to V2 in accordance of deprecation of docker-compose V1 on GitHub Actions runner's ubuntu image.
What this PR does / why we need it:
This PR modified the docker-compose command, which was deprecated in compose v1, to the docker compose command in accordance with compose v2.
This also resolves the failure of CI workflow due to Docker Compose V1 being deprecated on the runner's ubuntu image by actions/runner-images#10368
Which issue(s) this PR fixes:
Fixes #949
Related content
https://docs.docker.com/compose/migrate/
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist:
Summary by CodeRabbit
docker compose
command, enhancing compatibility and simplifying command usage.