Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker compose command to V2 #950

Merged
merged 2 commits into from
Aug 3, 2024
Merged

Conversation

fourjae
Copy link
Contributor

@fourjae fourjae commented Aug 3, 2024

What this PR does / why we need it:

This PR modified the docker-compose command, which was deprecated in compose v1, to the docker compose command in accordance with compose v2.

This also resolves the failure of CI workflow due to Docker Compose V1 being deprecated on the runner's ubuntu image by actions/runner-images#10368

Which issue(s) this PR fixes:

Fixes #949

Related content
https://docs.docker.com/compose/migrate/

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • [v] Added relevant tests or not required
  • [v] Didn't break anything

Summary by CodeRabbit

  • Chores
    • Updated CI workflow to use the newer docker compose command, enhancing compatibility and simplifying command usage.

Copy link

coderabbitai bot commented Aug 3, 2024

Walkthrough

The changes update the CI workflow and related documentation to replace docker-compose with docker compose. This transition addresses the compatibility issues arising from the deprecation of Docker Compose V1 on the CI runner's Ubuntu image, ensuring that the CI process continues to function correctly while maintaining the same workflow for building and running Docker containers.

Changes

Files Change Summary
.github/workflows/ci.yml, CONTRIBUTING.md, build/docker/README.md Updated command syntax from docker-compose to docker compose to align with Docker CLI improvements.

Assessment against linked issues

Objective Addressed Explanation
CI workflow doesn't work due to Docker Compose V1 being deprecated (✔️ #949)

Poem

In the CI land where rabbits play,
Docker commands now lead the way! 🐇✨
No more V1, we’ve hopped to V2,
Building and running, all fresh and new!
With each little change, our code takes flight,
A smoother workflow, all feels just right!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@krapie krapie self-assigned this Aug 3, 2024
@krapie krapie self-requested a review August 3, 2024 14:25
@krapie krapie added the enhancement 🌟 New feature or request label Aug 3, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 52d2732 and e0e58e2.

Files selected for processing (1)
  • .github/workflows/ci.yml (2 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/ci.yml

Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.31%. Comparing base (52d2732) to head (e0e58e2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #950   +/-   ##
=======================================
  Coverage   51.31%   51.31%           
=======================================
  Files          71       71           
  Lines       10679    10679           
=======================================
  Hits         5480     5480           
  Misses       4650     4650           
  Partials      549      549           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
build/docker/README.md (1)

8-8: Add missing article for clarity.

The sentence would be clearer with the addition of "the" before "docker compose command".

- through `docker compose` command.
+ through the `docker compose` command.
Tools
LanguageTool

[uncategorized] ~8-~8: You might be missing the article “the” here.
Context: ...required dependant applications through docker compose command. ```bash # Run ...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e0e58e2 and 5dd7e5b.

Files selected for processing (2)
  • CONTRIBUTING.md (1 hunks)
  • build/docker/README.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • CONTRIBUTING.md
Additional context used
LanguageTool
build/docker/README.md

[uncategorized] ~8-~8: You might be missing the article “the” here.
Context: ...required dependant applications through docker compose command. ```bash # Run ...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)

Additional comments not posted (2)
build/docker/README.md (2)

12-12: LGTM!

The command syntax is correctly updated to docker compose.


15-15: LGTM!

The command syntax is correctly updated to docker compose.

@krapie krapie changed the title update docker compose command Update docker compose command Aug 3, 2024
Copy link
Member

@krapie krapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@krapie krapie changed the title Update docker compose command Update docker compose command to v2 Aug 3, 2024
@krapie krapie changed the title Update docker compose command to v2 Update docker compose command to V2 Aug 3, 2024
@krapie krapie merged commit 54910c1 into yorkie-team:main Aug 3, 2024
3 checks passed
raararaara pushed a commit that referenced this pull request Oct 7, 2024
Update docker compose command to V2 in accordance of deprecation of docker-compose V1 on GitHub Actions runner's ubuntu image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🌟 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI workflow doesn't work due to Docker Compose V1 being deprecated on the runner's ubuntu image
2 participants