-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MD5 checksum in Metadata #225
Conversation
Added MD5 Checksum in metadata
✅ Deploy Preview for superfile ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
First of all, thank you very much for your contribution!! I think this is a nice feature, but since MD5 generation actually consumes performance and slows down getting metadata, could you make it switchable in |
if Config.MetadataMd5 {
// Get file MD5
} |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added Switchable MD5 Checksum
wow thanks so much for the quick update! |
I suggest adding a shortcut to add the checksum in the metadata. If I would like to check the checksum for one or two files, I wouldn't like it to add it for the whole session because of the performance issues. I upvote the permissions Great project btw |
This is a great idea to me! |
I'm working on creating a shortcut but it might take some time and should i make the permission switchable or just like a shortcut for single file? |
I think a single file is a good choice. If you have any questions, please feel free to ask :) |
Yes sir |
The permissions is something that can be benefited from session wide as it is not an expensive operation |
Added MD5 Checksum in metadata