Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MD5 checksum in Metadata #225

Merged
merged 5 commits into from
Jun 3, 2024
Merged

MD5 checksum in Metadata #225

merged 5 commits into from
Jun 3, 2024

Conversation

hyperionhex
Copy link
Contributor

Added MD5 Checksum in metadata
superfile

Added MD5 Checksum in metadata
Copy link

netlify bot commented May 31, 2024

Deploy Preview for superfile ready!

Name Link
🔨 Latest commit b7cec0a
🔍 Latest deploy log https://app.netlify.com/sites/superfile/deploys/665dda4d51c69900082b7bb8
😎 Deploy Preview https://deploy-preview-225--superfile.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hyperionhex hyperionhex changed the title Update function.go MD5 checksum in Metadata May 31, 2024
@yorukot
Copy link
Owner

yorukot commented May 31, 2024

First of all, thank you very much for your contribution!!

I think this is a nice feature, but since MD5 generation actually consumes performance and slows down getting metadata, could you make it switchable in config.toml?

@yorukot
Copy link
Owner

yorukot commented May 31, 2024

  1. Add option on src/superfile_config/config.toml
  2. Add type on src/internal/config_type.go
  3. Add
if Config.MetadataMd5 {
// Get file MD5
}

@hyperionhex
Copy link
Contributor Author

  1. Add option on src/superfile_config/config.toml
  2. Add type on src/internal/config_type.go
  3. Add
if Config.MetadataMd5 {
// Get file MD5
}

Done

Copy link
Contributor Author

@hyperionhex hyperionhex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Switchable MD5 Checksum

@yorukot yorukot merged commit 3f7f8df into yorukot:main Jun 3, 2024
4 checks passed
@yorukot
Copy link
Owner

yorukot commented Jun 3, 2024

wow thanks so much for the quick update!

@hyperionhex
Copy link
Contributor Author

brother I have one more idea what do you think about this?

superfile

@oppZ
Copy link

oppZ commented Jun 3, 2024

I suggest adding a shortcut to add the checksum in the metadata. If I would like to check the checksum for one or two files, I wouldn't like it to add it for the whole session because of the performance issues.
Also, I suggest adding the sha256 checksum as this is the checksum type usually available along with linux .iso files.

I upvote the permissions

Great project btw

@yorukot
Copy link
Owner

yorukot commented Jun 6, 2024

I suggest adding a shortcut to add the checksum in the metadata. If I would like to check the checksum for one or two files, I wouldn't like it to add it for the whole session because of the performance issues. Also, I suggest adding the sha256 checksum as this is the checksum type usually available along with linux .iso files.

This is a great idea to me!

@hyperionhex
Copy link
Contributor Author

I'm working on creating a shortcut but it might take some time and should i make the permission switchable or just like a shortcut for single file?

@yorukot
Copy link
Owner

yorukot commented Jun 6, 2024

I think a single file is a good choice.

If you have any questions, please feel free to ask :)

@hyperionhex
Copy link
Contributor Author

I think a single file is a good choice.

If you have any questions, please feel free to ask :)

Yes sir

@oppZ
Copy link

oppZ commented Jun 7, 2024

The permissions is something that can be benefited from session wide as it is not an expensive operation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants