Make install.sh
more robust to not being root
#258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just failing if
sudo
is not granted, the install script now tries to:./spf
to~/.local/bin
(which is the correct path for user executables according to the XDG Base Directory Spec)Here is an example of how it looks with these changes: (ignore the actual colors, my terminal's color profile is different)
One question I had is should I also mention that
~/.local/bin
has been added to~/.bashrc
(so that users of other shells i.e. fish/zsh/xonsh etc) would be able to add it to their configs themselves? I am in favour of adding it.Alternatively, we can try detecting shell and run respective command but not even
fzf
takes that approach - it asks you to run the right file yourself (out of some provided scripts)