Anshuman main branch #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AnshumanNeon
commented
Apr 7, 2024
AnshumanNeon
commented
- I don't think you should keep the binary files in your source code itself. So I have ignored it in .gitignore.
- I use a mac ver 10.15 so I tested it and it works well. The release you provided didn't work for macos so I had to download the source code and build it from scratch but it was easy.
- I have added a build.sh file which simplifies the process of building for both mac and linux users.
- I have also updated the README for the same changes.
- I also deleted the theme folder because you have the theme folder in ./src/.superfile dir and in the theme.zip file too. It was too redundant for it. You can just link the themes to their screenshots in the assets folder. The code for the themes folder can be held in the theme.zip file.
…e to not track it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.