Update image_preview.go #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JassonCordones
commented
Sep 9, 2024
JassonCordones
commented
- Added Error handling in hexToColor function.
- The ConvertImageToANSI function now uses colorToTermenv for all color conversions.
- Simplified the background color handling in ConvertImageToANSI.
- colorToTermenv function now takes a fallback color string, making it more flexible.
- Added error checking for the background color in ImagePreview.
- Added Error handling in hexToColor function. - The ConvertImageToANSI function now uses colorToTermenv for all color conversions. - Simplified the background color handling in ConvertImageToANSI. - colorToTermenv function now takes a fallback color string, making it more flexible. - Added error checking for the background color in ImagePreview.
✅ Deploy Preview for superfile ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hey, thanks a lot for your PR, really appreciate your contribution! 🙏 However, I noticed an issue after reviewing the updated version. In the new version (on the right), it seems like the background of the PNG file is no longer transparent, which affects the visual appearance of the image.
|
Fix transparent background in images
|
I just pushed a fix, please check |
|
I've committed some changes to address the issue. Could you please review them and let me know if everything looks good to you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.