Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic when deleting last file in directory #529

Merged
merged 2 commits into from
Dec 29, 2024

Conversation

sahinfalcon
Copy link
Contributor

Fixes #528.

Problem

If you try to delete the last file in a directory, the application would panic with an "index out of range [-1]" error. This occurred because the cursor position didn't reset properly after the deletion, leading to an invalid array
access in the file preview panel.

Solution

Added proper cursor position handling after file deletion:

  • if the current directory is empty, the cursor becomes 0
  • if the cursor is beyond last element, set it to last element position

Copy link

netlify bot commented Dec 29, 2024

Deploy Preview for superfile canceled.

Name Link
🔨 Latest commit 12b5823
🔍 Latest deploy log https://app.netlify.com/sites/superfile/deploys/6770c4dce219f40008ce0da1

@yorukot yorukot merged commit 6a644c1 into yorukot:main Dec 29, 2024
4 checks passed
@yorukot
Copy link
Owner

yorukot commented Dec 29, 2024

Thank you so much!

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jan 6, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [yorukot/superfile](https://github.com/yorukot/superfile) | patch | `v1.1.6` -> `v1.1.7` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>yorukot/superfile (yorukot/superfile)</summary>

### [`v1.1.7`](https://github.com/yorukot/superfile/blob/HEAD/changelog.md#v117)

[Compare Source](yorukot/superfile@v1.1.6...v1.1.7)

> 2024-01-05

##### Update

-   OneDark Theme added [`#477`](yorukot/superfile#477)
-   Add keys PageUp and PageDown for better navigation [`#498`](yorukot/superfile#498)
-   Add hotkey for copying PWD to clipboard [`#510`](yorukot/superfile#510)
-   Add desktop entry [`#501`](yorukot/superfile#501)
-   Enable cd_on_quit when current directory is home directory [`#518`](yorukot/superfile#518)
-   Edit superfile config [`#509`](yorukot/superfile#509)

##### Bug fix

-   Fix rendering directory symlinks as directories, not files [`#481`](yorukot/superfile#481)
-   Fix opening files on Windows [`#496`](yorukot/superfile#496)
-   Fix lag in dotfile toggle with multiple panels [`#499`](yorukot/superfile#499)
-   Fix parent directory navigation on Windows [`#502`](yorukot/superfile#502)
-   Fix panic when deleting last file in directory [`#529`](yorukot/superfile#529)
-   Fix panic when scrolling through an empty metadata list [`#531`](yorukot/superfile#531)
-   Fix panic when trying to get folder size without needed permissions [`#532`](yorukot/superfile#532)
-   Fix lag when navigating directories with large image files [`#525`](yorukot/superfile#525)
-   Fix typo in welcome message [`#494`](yorukot/superfile#494)

##### Optimization

-   Optimize file move operation [`#522`](yorukot/superfile#522)
-   Optimize file extraction [`#524`](yorukot/superfile#524)
-   Warn overwrite when renaming files [`#526`](yorukot/superfile#526)
-   Work without trash [`#527`](yorukot/superfile#527)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45MC40IiwidXBkYXRlZEluVmVyIjoiMzkuOTAuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Panics when deleting a file
2 participants