Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spanner: fix lint error #334

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Conversation

danielnorberg
Copy link
Contributor

@danielnorberg danielnorberg commented Dec 23, 2024

Fix lint error introduced in #332

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> spanner/src/apiv1/mod.rs:35:49
   |
35 |         cm.conn().with_metadata(client_metadata(&DATABASE))
   |                                                 ^^^^^^^^^ help: change this to: `DATABASE`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default

Noting though that this is only in test code. We should perhaps change CI to cargo clippy --all-targets to catch lint errors in test code as well.

@danielnorberg danielnorberg changed the title spanner: fix lint warning spanner: fix lint error Dec 23, 2024
@yoshidan yoshidan added the safe to test safe to test label Dec 27, 2024
@yoshidan yoshidan merged commit 55e6afa into yoshidan:main Dec 27, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test safe to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants