Revive of PR #1686. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I used to work on the specification update to support the ServiceWorker static routing API (https://github.com/WICG/service-worker-static-routing-api) w3c#1686 However, I accidentally closed it by force-sync to the ServiceWorker specification's repository HEAD. This CL is for reviving it.
|
@domenic @sisidovski Can I ask your review for this? |
domenic
suggested changes
Nov 29, 2023
sisidovski
reviewed
Nov 30, 2023
domenic
reviewed
Dec 4, 2023
domenic
reviewed
Dec 4, 2023
Considering the future update of the condition, we should mark the case handled as one of conditions. Also, we need to make it extensible.
It was flipped by mistake.
I have updated the specification to make the case handled. |
|
@sisidovski Can I ask you to take another look? Does it look good? |
sisidovski
reviewed
Dec 6, 2023
sisidovski
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used to work on the specification update to support the ServiceWorker static routing API
(https://github.com/WICG/service-worker-static-routing-api) w3c#1686
However, I accidentally closed it by force-sync to the ServiceWorker specification's repository HEAD.
This CL is for reviving it.
Preview | Diff