Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore errors while dropping a lock #37

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Ignore errors while dropping a lock #37

merged 1 commit into from
Jan 23, 2023

Conversation

nathaniel-daniel
Copy link
Contributor

Fixes #34. Let me know if I should also add a function like fn unlock(self) -> Result<Self, (self, std::io::Error)> to the locks.

yoshuawuyts
yoshuawuyts approved these changes Jan 23, 2023
View reviewed changes
Copy link
Owner

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@yoshuawuyts yoshuawuyts merged commit d04a0ce into yoshuawuyts:master Jan 23, 2023
@nathaniel-daniel
Copy link
Contributor Author

Thanks!

@nathaniel-daniel nathaniel-daniel deleted the no-panic-on-drop branch January 24, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid panic on dropping lock
2 participants
@nathaniel-daniel @yoshuawuyts