fixes an issue where single quote would be considered invalid literal #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 14, 2022
|
The logic part is perfect. However, the RFC errata has not yet been accepted, and even after it got accepted it wouldn't appear in the main RFC text. Therefore, could you add a link to the errata or the clarification thread above the single quote entry? |
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
|
thanks for the quick review. Added. let me know if you need anything else! |
yosida95
approved these changes
Apr 19, 2022
|
Thanks for merging! Let me know when the tag is ready! |
|
I just published v3.0.2. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14