Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test enhancement #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Test enhancement #22

wants to merge 1 commit into from

Conversation

peter279k
Copy link

Changed log

  • Add more tests.
  • Set the phpunit version in require-dev.
  • Use composer update because it can let the different PHP versions to install proper packages when executing Travis CI build.

@yosymfony yosymfony closed this May 31, 2018
@peter279k
Copy link
Author

Can you explain why closing PR?

@yosymfony yosymfony reopened this Jun 9, 2018
@yosymfony
Copy link
Owner

It was a mistake

@peter279k
Copy link
Author

@yosymfony, thank you for your reply.
If possible, can you review them and suggest the recommendation?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peter279k @yosymfony