Skip to content

misc cleanups #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 22 commits into
base: master
Choose a base branch
from
Draft

misc cleanups #1

wants to merge 22 commits into from
+724 −754

Conversation

yotamofek
Copy link
Owner

No description provided.

@yotamofek yotamofek force-pushed the misc-cleanups branch 8 times, most recently from a3c38bf to 6640154 Compare January 18, 2025 07:10
yotamofek
yotamofek commented Jan 23, 2025
View reviewed changes
compiler/rustc_hir/src/hir.rs Outdated
@@ -205,7 +205,7 @@ pub type UsePath<'hir> = Path<'hir, SmallVec<[Res; 3]>>;

impl Path<'_> {
pub fn is_global(&self) -> bool {
!self.segments.is_empty() && self.segments[0].ident.name == kw::PathRoot
matches!(self.segments, [PathSegment { ident: Ident { name: kw::PathRoot, .. }, .. }, ..])
Copy link
Owner Author

@yotamofek yotamofek Jan 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use .get(0)

@yotamofek yotamofek force-pushed the misc-cleanups branch 4 times, most recently from bc15855 to 02d77dd Compare January 28, 2025 20:21
yotamofek
yotamofek commented Jan 28, 2025
View reviewed changes
compiler/rustc_resolve/src/diagnostics.rs Outdated
}

None
extern_crate_names.sort_by_key(|&name| Reverse(name));
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope

@yotamofek yotamofek marked this pull request as draft February 6, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preechapon-cmd preechapon-cmd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yotamofek @preechapon-cmd