Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small settings menu improvements #108

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Small settings menu improvements #108

merged 1 commit into from
Jul 20, 2023

Conversation

M00NJ
Copy link
Member

@M00NJ M00NJ commented Jul 20, 2023

  • use switches instead of checkboxes
  • use primary color to highlight settings categories
  • make theme picker pill shaped
  • reduce repetitive code by removing horizontal padding from all settings items (unnecessary because already handled by colum)
  • change 1 line requested in last PR

Before:
Screenshot_20230720-151836

After:
Screenshot_20230720-151832

@M00NJ
Small settings menu improvements
4f333a2 
- use switches instead of checkboxes
- use primary color to highlight settings categories
- make theme picker pill shaped
- remove horizontal padding from all settings items (unnecessary because already handled by colum)
- give timer picker setting a more concise name
- change 1 line requested in last PR
Bnyro
Bnyro approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@Bnyro Bnyro merged commit 4d274db into you-apps:main Jul 20, 2023
@M00NJ M00NJ deleted the settings-screen-improvements branch July 20, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bnyro Bnyro Bnyro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M00NJ @Bnyro