fix: improved stopwatch service and notification #297
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
Demo
Screen_recording_old.mp4
Screen_recording_new.mp4
Other tests
I started the stopwatch. Cleared the app from task view and waited for about a half an hour with the device screen turned off. The stopwatch service managed to survive that whole time without crashing.
Footnotes
This should be more responsive than starting and stopping the service for every stopwatch run ↩
This prevents leaking a context object in the viewmodel ↩