Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong 1 hour ahead/behind calculation #345

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

fix: wrong 1 hour ahead/behind calculation #345

wants to merge 4 commits into from

Conversation

OGKUsername
Copy link

Closes #341

SuhasDissa
SuhasDissa requested changes May 13, 2024
View reviewed changes
Copy link
Member

@SuhasDissa SuhasDissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a good solution. The issue only occurs in some timezones. Probably the ones that have DST.

@OGKUsername
Copy link
Author

This is not a good solution. The issue only occurs in some timezones. Probably the ones that have DST.

Ah, that make sense!! I had neglected to take into account other timezones or DST being an issue! 😅

@OGKUsername OGKUsername marked this pull request as draft May 13, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuhasDissa SuhasDissa SuhasDissa requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong "1 hour ahead" calculation
2 participants
@OGKUsername @SuhasDissa